[Webkit-unassigned] [Bug 138562] [GStreamer] GstGL support in the video sink

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 9 03:36:44 PST 2015


--- Comment #21 from Víctor M. Jáquez L. <vjaquez at igalia.com> ---
Comment on attachment 244249
  --> https://bugs.webkit.org/attachment.cgi?id=244249

View in context: https://bugs.webkit.org/attachment.cgi?id=244249&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:309
> +    if (!gst_buffer_map(buffer, &mapInfo, static_cast<GstMapFlags>(GST_MAP_READ | GST_MAP_GL))) {

Mapping might be expensive if the buffer stored in the GPU's memory. When using GstVideoGLTextureUploadMeta, this mapping is no necessary, but here, the meta usage is tried after the buffer mapping.

Also, AFAIK, gst_video_frame_map() is preferred over gst_buffer_map()

I'll post a patch which goes above yours addressing this issue.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150209/b2581054/attachment-0002.html>

More information about the webkit-unassigned mailing list