[Webkit-unassigned] [Bug 140664] Web Inspector: Make collapsed sidebars undraggable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140664

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246242|review?                     |review+
              Flags|                            |

--- Comment #7 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 246242
  --> https://bugs.webkit.org/attachment.cgi?id=246242
Patch (using display: none)

View in context: https://bugs.webkit.org/attachment.cgi?id=246242&action=review

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:54
> +    this._widthBeforeResize = 0;
> +    this._resizerMouseDownX = 0;

No need to create the properties here.

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:274
> +        this._widthBeforeResize = this.width;
> +        this._resizerMouseDownX = event.pageX;

They will be create as needed here.

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:305
> +        this._widthBeforeResize = 0;
> +        this._resizerMouseDownX = 0;

Nit: No need to reset them, they will be initialized again next time. I just like to delete ephemeral properties when done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150208/63e7f43b/attachment-0002.html>