[Webkit-unassigned] [Bug 141295] Switch to file backed buffer when resource is cached to disk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141295

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246121|review?                     |review+
              Flags|                            |

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 246121
  --> https://bugs.webkit.org/attachment.cgi?id=246121
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246121&action=review

r=me % a few comments.

>> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:448
>> +void NetworkCacheStorage::store(const NetworkCacheKey& key, const Entry& entry, StoreCompletionHandler completionHandler)
> 
> Since these std::function are passed by value, don't we want to WTF::move() them into the StoreOperation struct?

or pass them by const ref.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150205/3c9d391b/attachment-0002.html>