[Webkit-unassigned] [Bug 141295] Switch to file backed buffer when resource is cached to disk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 5 12:37:49 PST 2015


--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 246121
  --> https://bugs.webkit.org/attachment.cgi?id=246121

View in context: https://bugs.webkit.org/attachment.cgi?id=246121&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:146
> +    typedef std::function<bool (std::unique_ptr<Entry>)> RetriveCompletionHandler;


> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:448
> +void NetworkCacheStorage::store(const NetworkCacheKey& key, const Entry& entry, StoreCompletionHandler completionHandler)

Since these std::function are passed by value, don't we want to WTF::move() them into the StoreOperation struct?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150205/64b26776/attachment-0002.html>

More information about the webkit-unassigned mailing list