[Webkit-unassigned] [Bug 141225] Web Inspector: REGRESSION: Inline SourceMap resources show empty content when opened.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 4 18:58:59 PST 2015


--- Comment #12 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 246060
  --> https://bugs.webkit.org/attachment.cgi?id=246060
[PATCH] Fix based on feedback.

View in context: https://bugs.webkit.org/attachment.cgi?id=246060&action=review

> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:107
> +            // There was an error calling NetworkAgent.loadResource.
> +            // FIXME: https://bugs.webkit.org/show_bug.cgi?id=141266 needs to change this condition to be compatible
> +            // with legacy iOS versions. As it is those versions would hit this code path and stop execution.
> +            throw new Error(error);

I'm still not sure why this needs to throw. We don't want to break the UI.

> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:133
> +            sourceMapResourceLoadError.call(this, "No NetworkAgent.loadResource");

Can we just remove this call or use sourceMapResourceNotAvailable with empty data and a 500 status code or something?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150205/f1c7d429/attachment-0002.html>

More information about the webkit-unassigned mailing list