[Webkit-unassigned] [Bug 141273] Avoid copying std::functions across threads in NetworkCacheStorage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141273

Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246067|review?                     |review+
              Flags|                            |

--- Comment #4 from Andreas Kling <akling at apple.com> ---
Comment on attachment 246067
  --> https://bugs.webkit.org/attachment.cgi?id=246067
rebased

View in context: https://bugs.webkit.org/attachment.cgi?id=246067&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:359
> +    auto& retrieve = *retrieveOperation;

Whenever I see code like this it makes me wonder if we should have a never-null unique_ptr.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150205/3dd6948d/attachment-0002.html>