[Webkit-unassigned] [Bug 141225] Web Inspector: REGRESSION: Inline SourceMap resources show empty content when opened.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141225

--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 246000
  --> https://bugs.webkit.org/attachment.cgi?id=246000
[PATCH] Attempted fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246000&action=review

> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:106
> +        function sourceMapResourceLoadError(error)
>          {
> +            // There was an error calling NetworkAgent.loadResource.
> +            throw new Error(error);
> +        }

I don't think we want to throw an exception in our code when this happens. Doesn't this break iOS 6 and iOS 7 inspection of a page with Source Map contents?

> Source/WebInspectorUI/UserInterface/Models/SourceMapResource.js:113
> +            var error = parameters.error;
> +            var content = parameters.content;
> +            var mimeType = parameters.mimeType;
> +            var statusCode = parameters.status;

This could be written more simply:

  var {error, content, mimeType, statusCode} = parameters;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150204/ca66f39f/attachment-0002.html>