[Webkit-unassigned] [Bug 141096] WebGL2 (3.7.1): New queries in getParameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141096

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245748|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 245748
  --> https://bugs.webkit.org/attachment.cgi?id=245748
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245748&action=review

r=me, but please do not land until you are ready to fix the Windows build issue.

> Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:45
> +        const Vector<bool>& value = info.getBoolArray();

This could be 'const auto& values = info.getBoolArray()'

> Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:46
> +        for (size_t ii = 0; ii < value.size(); ++ii)

This would be better as a C++11 loop:  for (const auto& value : values)

> Source/WebCore/bindings/js/JSWebGL2RenderingContextCustom.cpp:60
> +    default:

Maybe better as ASSERT_NOT_REACHED?

> Source/WebCore/html/canvas/WebGL2RenderingContext.cpp:1005
> +        // FIXME: should we always return 0 for this?

We should have a bug here so we don't forget to revisit this issue.

Also, since this seems to be a copy/paste from elsewhere, maybe this question was already answered (where we decided to not return 0) and we could remove the comment?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:386
> +        // FIXME: should we always return 0 for this?

Ditto (File bug so we don't forget)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150202/16f70300/attachment-0002.html>