[Webkit-unassigned] [Bug 151998] [GTK] Add an API to add a custom tab into the print dialog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 30 20:55:26 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=151998

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #3) 
> You really do have to obey style checker for new properties, so indent four
> spaces:

And for the signals as well

> > Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.h:105
> > +                                          (WebKitPrintOperation *printOperation,
> 
> WebKitPrintOperation *print_operation, star moved, and with an underscore.
> Since it's a public header, welcome back to GNOME style. :)

I got a bit confused here; you do have the * in the right place on this line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151231/f02c4c73/attachment.html>


More information about the webkit-unassigned mailing list