[Webkit-unassigned] [Bug 149615] [ES6] Arrow function syntax. Arrow function specific features. Lexical bind "super" property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149615

--- Comment #12 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 267762
  --> https://bugs.webkit.org/attachment.cgi?id=267762
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=267762&action=review

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:805
>> +            if (needsToUpdateArrowFunctionContext()) {
> 
> This condition confuses me here. Don't we only care about this if the function we're creating is an arrow function?
> If it's not an arrow function, shouldn't we give it DerivedContextType::None?

Ohh, OK. I got it. I've added new condition to check if we're going to create new arrow function

>> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:763
>> +
> 
> style: revert newline

Removed

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151222/2d63c8b9/attachment.html>