[Webkit-unassigned] [Bug 152431] Fix the !ENABLE(VIDEO) build after r192953 for <picture> element introduction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152431

--- Comment #3 from Olivier Blin <olivier.blin at softathome.com> ---
(In reply to comment #2)
> Comment on attachment 267637 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=267637&action=review
> 
> > Source/WebCore/html/HTMLSourceElement.cpp:67
> > +        else
> > +#endif
> > +        if (is<HTMLPictureElement>(*parent))
> 
> This is strange, but it's clear what is going on and has the correct
> behavior, and I can't make anything that does this that doesn't also look
> strange.

This is indeed a bit weird, but I didn't find a better way, and saw that this pattern is already used in a few places, like HTMLOptionElement.cpp

Thanks for the review!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151218/ad5508aa/attachment-0001.html>