[Webkit-unassigned] [Bug 147602] [INTL] Implement Intl.NumberFormat.prototype.resolvedOptions ()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147602

--- Comment #17 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
I've made several changes to this patch to bring it into line with the Intl.Collator patch (Bug 147604).

(In reply to comment #10)
> Comment on attachment 264455 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=264455&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/runtime/IntlNumberFormat.h:87
> > +    unsigned m_minimumIntegerDigits;
> > +    unsigned m_minimumFractionDigits;
> > +    unsigned m_maximumFractionDigits;
> 
> These need initializers.
> 
> > Source/JavaScriptCore/runtime/IntlNumberFormat.h:91
> > +    bool m_useGrouping;
> 
> And this.

Done.

> > Source/JavaScriptCore/runtime/IntlNumberFormatConstructor.cpp:71
> > +#ifndef NDEBUG
> > +    ASSERT(key == "nu");
> > +#else
> > +    UNUSED_PARAM(key);
> > +#endif
> 
> You can use ASSERT_UNUSED here instead.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151218/144b1df8/attachment.html>