[Webkit-unassigned] [Bug 152342] New: include proper header to use inline function isMainFrame
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 16 10:18:08 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=152342
Bug ID: 152342
Summary: include proper header to use inline function
isMainFrame
Classification: Unclassified
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebCore Misc.
Assignee: webkit-unassigned at lists.webkit.org
Reporter: honglh at gmail.com
When I am building webcore in debug mode, the build failed
../../lib/libWPEWebKit.so.0.0.1: error: undefined reference to 'WebCore::Frame::isMainFrame() const'
The issue may be introduced by https://bugs.webkit.org/show_bug.cgi?id=150416
Since Frame::isMainFrame() is inline function defined in MainFrame.h,
The change from 150416 introduced in DEBUG mode a reference to isMainFrame without using #include "MainFrame.h"
Adding the following lines in Source/WebCore /rendering/RenderObject.cpp
resolved the build failure.
diff --git a/Source/WebCore/rendering/RenderObject.cpp b/Source/WebCore/rendering/RenderObject.cpp
index 8b74a66..5365daa 100644
--- a/Source/WebCore/rendering/RenderObject.cpp
+++ b/Source/WebCore/rendering/RenderObject.cpp
@@ -72,6 +72,9 @@
#include <algorithm>
#include <stdio.h>
#include <wtf/RefCountedLeakCounter.h>
+#ifndef NDEBUG
+#include "MainFrame.h"
+#endif
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151216/3a028ffb/attachment-0001.html>
More information about the webkit-unassigned
mailing list