[Webkit-unassigned] [Bug 149338] [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149338

--- Comment #164 from Filip Pizlo <fpizlo at apple.com> ---
(In reply to comment #160)
> (In reply to comment #159)
> > (In reply to comment #158)
> > > (In reply to comment #157)
> > > > (In reply to comment #156)
> > > > > (In reply to comment #155)
> > > > > > (In reply to comment #154)
> > > > > > > Did anyone run performance tests on this?
> > > > > > 
> > > > > > https://bugs.webkit.org/attachment.cgi?id=265179
> > > > > 
> > > > > That's in debug mode.  Debug mode performance numbers are not meaningful.
> > > > > 
> > > > > We should make sure to do release mode performance testing of patches like
> > > > > this.
> > > > 
> > > > I didn't run the tests so I don't know for sure but the results text result
> > > > looks like a release build. What made you say it was Debug?
> > > 
> > > The performance is very bad in absolute terms.
> > > 
> > > I also just noticed that the performance numbers are super noisy.
> > > 
> > > Either way, someone needs to run independent performance numbers on this
> > > because these don't look right.
> > 
> > I'll run them tonight.
> 
> When measuring perf in Linux, I can see these noisy result.
> On the other hand, when executing it in OSX with exactly the same
> run-jsc-benchmarks cmd,
> I can get somewhat solid result. So usually I measure perf on OSX machine.
> (In Linux, I ensured that cpu freq is fixed as "performance" mode, not
> "ondemand")
> I guess that is due to FTL's system allocator... But anyway, retaking it in
> OSX is nice.

I've run benchmarks on Linux, and I don't see it being this slow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151216/181f3241/attachment.html>