[Webkit-unassigned] [Bug 152290] Builtin source should be minified more

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152290

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |joepeck at webkit.org
                   |kit.org                     |

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
I'll handle some basic stuff, like stripping the empty comments and empty lines. I think it leads to even more readable code in the results anyways:

BEFORE:

> const int s_moduleLoaderObjectRequestFetchCodeLength = 669;
> const char* s_moduleLoaderObjectRequestFetchCode =
>     "(function (key)\n" \
>     "{\n" \
>     "    //\n" \
>     "\n" \
>     "    \"use strict\";\n" \
>     "\n" \
>     "    var entry = this.ensureRegistered(key);\n" \
>     "    if (entry.state > this.Link) {\n" \
>     "        var deferred = @newPromiseCapability(@InternalPromise);\n" \
>     "        deferred. at reject.@call(undefined, new @TypeError(\"Requested module is already ready to be executed.\"));\n" \
>     "        return deferred. at promise;\n" \
>     "    }\n" \
>     "\n" \
>     "    if (entry.fetch)\n" \
>     "        return entry.fetch;\n" \
>     "\n" \
>     "    var loader = this;\n" \
>     "\n" \
>     "    //\n" \
>     "    //\n" \
>     "    //\n" \
>     "    //\n" \
>     "    //\n" \
>     "    //\n" \
>     "    var fetchPromise = this.fetch(key).then(function (payload) {\n" \
>     "        loader.setStateToMax(entry, loader.Translate);\n" \
>     "        return payload;\n" \
>     "    });\n" \
>     "    entry.fetch = fetchPromise;\n" \
>     "    return fetchPromise;\n" \
>     "})\n" \
> ;

AFTER:

> const int s_moduleLoaderObjectRequestFetchCodeLength = 615;
> const char* s_moduleLoaderObjectRequestFetchCode =
>     "(function (key)\n" \
>     "{\n" \
>     "    \"use strict\";\n" \
>     "    var entry = this.ensureRegistered(key);\n" \
>     "    if (entry.state > this.Link) {\n" \
>     "        var deferred = @newPromiseCapability(@InternalPromise);\n" \
>     "        deferred. at reject.@call(undefined, new @TypeError(\"Requested module is already ready to be executed.\"));\n" \
>     "        return deferred. at promise;\n" \
>     "    }\n" \
>     "    if (entry.fetch)\n" \
>     "        return entry.fetch;\n" \
>     "    var loader = this;\n" \
>     "    var fetchPromise = this.fetch(key).then(function (payload) {\n" \
>     "        loader.setStateToMax(entry, loader.Translate);\n" \
>     "        return payload;\n" \
>     "    });\n" \
>     "    entry.fetch = fetchPromise;\n" \
>     "    return fetchPromise;\n" \
>     "})\n" \
> ;

I didn't go all out and minify everything though. I think this is a good balance.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151215/007833b1/attachment-0001.html>