[Webkit-unassigned] [Bug 152255] New: We should not employ the snippet code in the DFG if no OSR exit was previously encountered.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152255

            Bug ID: 152255
           Summary: We should not employ the snippet code in the DFG if no
                    OSR exit was previously encountered.
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

We already tried to do this but was doing it wrong.  The is what we do now:

     if (Node::shouldSpeculateUntypedForArithmetic(leftChild.node(), rightChild.node())
         || m_graph.hasExitSite(node->origin.semantic, BadType)) {
         fixEdge<UntypedUse>(leftChild);
         fixEdge<UntypedUse>(rightChild);
         ...

The || should be a &&.  We only want to employ the snippet code if we have actually encountered an OSR exit due to untyped operands not being supported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151214/6cbe81dc/attachment.html>