[Webkit-unassigned] [Bug 152223] New: Move the API(s) from B3MathExtras.h into FTL::Output

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152223

            Bug ID: 152223
           Summary: Move the API(s) from B3MathExtras.h into FTL::Output
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

We need to keep the layering to a minimum.  We already have a layer that is meant to help you generate low-level IR, and that's called FTL::Output.  So, anytime we are tempted to add helpers that generate B3 IR on behalf of a client, we should just put that into FTL::Output.

Also, anytime you create a helper that generates IR that consists of multiple basic blocks, you need to be mindful of where you insert those blocks.  It's not good to just put them at the end of the procedure, since that breaks any range-based analyses.  It also makes IR hard to read.  This is why FTL::Output has all of this functionality about "inserting blocks before".  So, in its current form, the API in B3MathExtras.h is suboptimal and produces weird-looking IR, and to fix that we would need to endow it with FTL::Output's smarts.  Seems better to just move it to FTL::Output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151213/09baef14/attachment-0001.html>