[Webkit-unassigned] [Bug 152181] Refactoring HTMLMediaElement getStartDate() implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152181

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 267179
  --> https://bugs.webkit.org/attachment.cgi?id=267179
Just checking if this change may not break other tests

View in context: https://bugs.webkit.org/attachment.cgi?id=267179&action=review

This patch should only contain the change to HTMLMediaElement.idl. Deleting all the unneeded code can be done in a follow-up that does not change behavior.

> Source/WebCore/bindings/js/JSDOMBinding.cpp:124
>  JSValue jsDateOrNull(ExecState* exec, double value)
>  {
> -    if (!std::isfinite(value))
> +    if (std::isinf(value))
>          return jsNull();
> +    if (std::isnan(value))
> +        return DateInstance::create(exec, exec->lexicalGlobalObject()->dateStructure());
>      return DateInstance::create(exec->vm(), exec->lexicalGlobalObject()->dateStructure(), value);
>  }

This changes the behavior for every callers of jsDateOrNull when the value is a NaN. We do not want to make that global change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151213/5c594de4/attachment.html>