[Webkit-unassigned] [Bug 119190] "Illegal instruction" crash on AMD Geode CPU

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 03:27:59 PST 2015


--- Comment #7 from Alberto Garcia <berto at igalia.com> ---
(In reply to comment #6)
> > Source/JavaScriptCore/runtime/VM.cpp:140
> > +#if CPU(X86)
> > +    if (!MacroAssembler::supportsFloatingPoint())
> > +        return false;
> > +#endif
> I don't think if we should disable JIT here with disabling assembler if
> !supportsFloatingPoint().
> ( Additionally supportsFloatingPoint() == isSSE2Present() on X86, it would
> be better to use isSSE2Present(). )

isSSE2Present() is private

> Of course it can be a good workaround to disable JIT until somebody
> trace down which SSE2 instruction is emitted and where. The proper
> fix would be to make JIT not to emit SSE2 instructions if
> !isSSE2Present().

> There are many ASSERT(isSSE2Present()) assertions in
> MacroAssermblerX86(Common).h files.  I think one of them should hit
> in debug mode.

Yeah, my question is whether upstream is still interested in this or

I'll try debugging those assertions as you suggest, but if I don't
find an easy fix I think I'll use this workaround downstream, at least
for the time being.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151209/cd95d70c/attachment.html>

More information about the webkit-unassigned mailing list