[Webkit-unassigned] [Bug 119190] "Illegal instruction" crash on AMD Geode CPU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119190

--- Comment #6 from Csaba Osztrogonác <ossy at webkit.org> ---
Comment on attachment 266982
  --> https://bugs.webkit.org/attachment.cgi?id=266982
Disable the JIT on x86 if there's no SSE2

View in context: https://bugs.webkit.org/attachment.cgi?id=266982&action=review

> Source/JavaScriptCore/runtime/VM.cpp:140
> +#if CPU(X86)
> +    if (!MacroAssembler::supportsFloatingPoint())
> +        return false;
> +#endif

I don't think if we should disable JIT here with disabling assembler if !supportsFloatingPoint().
( Additionally supportsFloatingPoint() == isSSE2Present() on X86, it would be better to use isSSE2Present(). )

Of course it can be a good workaround to disable JIT until somebody trace down which
SSE2 instruction is emitted and where. The proper fix would be to make JIT not to
emit SSE2 instructions if !isSSE2Present(). 

There are many ASSERT(isSSE2Present()) assertions in MacroAssermblerX86(Common).h files.
I think one of them should hit in debug mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151209/f10c30a2/attachment.html>