[Webkit-unassigned] [Bug 115600] [GTK] Allow to save and restore session

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 8 10:41:52 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=115600

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Comment on attachment 266798 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=266798&action=review
> > > 
> > > > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewSessionState.cpp:136
> > > > +    g_return_val_if_fail(state, nullptr);
> > > > +    IPC::ArgumentEncoder encoder;
> > > > +    encoder << state->sessionState.backForwardListState;
> > > > +    encoder << state->sessionState.renderTreeSize;
> > > > +    encoder << state->sessionState.provisionalURL;
> > > > +    return g_bytes_new(encoder.buffer(), encoder.bufferSize());
> > > 
> > > NO.
> > > 
> > > Don't do this, we DON'T want to rely on the IPC encoding for this.
> > 
> > Ok, I simply didn't know it. What's the right way then? Should I use my own
> > encoding/decoding thing?
> 
> Yes. Preferably something that can be extended without breaking the format.
> 
> FWIW, the reason we don't want this is because it means we can't change the
> IPC format without breaking compat. We did this on OS X in the past and it
> caused us lots of pain.

Ok, understood, thanks for the explanation. I'll rework it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151208/5e202cb0/attachment.html>


More information about the webkit-unassigned mailing list