[Webkit-unassigned] [Bug 115600] [GTK] Allow to save and restore session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115600

Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266798|review?                     |review-
              Flags|                            |

--- Comment #7 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 266798
  --> https://bugs.webkit.org/attachment.cgi?id=266798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266798&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewSessionState.cpp:136
> +    g_return_val_if_fail(state, nullptr);
> +    IPC::ArgumentEncoder encoder;
> +    encoder << state->sessionState.backForwardListState;
> +    encoder << state->sessionState.renderTreeSize;
> +    encoder << state->sessionState.provisionalURL;
> +    return g_bytes_new(encoder.buffer(), encoder.bufferSize());

NO.

Don't do this, we DON'T want to rely on the IPC encoding for this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151207/17ab8982/attachment-0001.html>