[Webkit-unassigned] [Bug 151243] Use multiple iOS simulator instead of multiple apps on single simulator for running layout-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151243

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #266808|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 266808
  --> https://bugs.webkit.org/attachment.cgi?id=266808
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266808&action=review

> Tools/Scripts/webkitpy/port/ios.py:78
> +    num_workers = None

Do we need this despite default_child_processes being memoized?

> Tools/Scripts/webkitpy/port/ios.py:135
> +        num_cpu_cores = self._executive.cpu_count() / 2

For consistency, this should have "count" in the name. From the way it's used, I suggest a name like "best_child_process_count_for_cpu".

> Tools/Scripts/webkitpy/port/ios.py:139
> +        maximum_simulator_count_on_this_system = (system_process_count_limit - current_process_count) // self.PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE

Please add a FIXME about checking the amount of RAM.

> Tools/Scripts/webkitpy/port/ios.py:142
> +            _log.info('Please increase the process and file limit to launch more Simulators')

Where do we check the file limit?

Also, let's at least log the same info that Mac does:

                _log.warning("This machine could support %s child processes, but only has enough memory for %s." % (default_count, supportable_instances))

> Tools/Scripts/webkitpy/port/ios.py:144
> +            # FIXME: add url for webpage explaining how to increase these limits

WebKit style is to start FIXME with an upper case letter, and end with a period (i.e. to have a complete sentence).

> Tools/Scripts/webkitpy/port/ios.py:226
> +            if (int(self.host.platform._platform_module.mac_ver()[0].strip().replace("10.", "")) < 12):

I suggest comparing to "10.10" and "10.11" instead - that way it will be easier to find and delete in the future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151207/d5d810ca/attachment.html>