[Webkit-unassigned] [Bug 151888] New: TestNetscapePlugIn: Fix remaining static analyzer warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151888

            Bug ID: 151888
           Summary: TestNetscapePlugIn: Fix remaining static analyzer
                    warnings
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: lforschler at apple.com

Fix the remaining static analyzer warnings in TestNetscapePlugIn:

Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
        CRASH();
        ^~~~~~~
Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
    ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
    ^~~~~~~~~~~~~~~~
Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
    return obj->pluginTest->NPP_SetWindow(window);
           ^~~~~~~~~~~~~~~
2 warnings generated.

The first issue requires using __builtin_trap() on clang/gcc builds.

The second is just a matter of adding an early return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151204/8a257a8d/attachment.html>