[Webkit-unassigned] [Bug 151755] New: AX: AXObjectCacheMac is passing WebCore enum values directly to VoiceOver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151755

            Bug ID: 151755
           Summary: AX: AXObjectCacheMac is passing WebCore enum values
                    directly to VoiceOver
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dmazzoni at google.com
                CC: webkit-bug-importer at group.apple.com

As one example, in AXObjectCacheMac.mm when it's populating the userInfo dictionary to pass to AXPostNotificationWithUserInfo:

  [userInfo setObject:[NSNumber numberWithInt:intent.type] forKey:NSAccessibilityTextStateChangeTypeKey];

However, intent.type is of type AXTextStateChangeType, an enum defined in WebCore/accessibility/AXTextStateChangeIntent.h, and that numeric value is being passed directly to VoiceOver without any translation. As it is now, adding a new enum value to AXTextStateChangeType (in cross-platform code) would probably break WebKit on Mac.

In addition to separating the cross-platform constants from the Mac-specific constants, it'd be fantastic if you could document the protocol a bit more, since none of these keys appear in the 10.11 SDK or anywhere online yet.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151202/d9935046/attachment.html>