[Webkit-unassigned] [Bug 148520] Text areas resizer and scrollbars shouldn't be rendered while printing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148520

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 265946 [details]
> Updated patch
> 
> Patch is OK but I’d prefer not to make the printing mechanism, already
> messy, so much messier. I think this makes things a little worse by
> sprinkling more printing-specific code in some, but not all, places that
> deal with scroll bars. Originally I had many comments about how to simplify
> this, but now I think I have only one comment: Seems we’d want to use the
> style system for this if possible instead of adding special case code for
> printing. There’s a media type of "print" and we can eliminate both
> scrollbars and resizers with !important style rules. Can we try this?
> 
> @media print {
>     ::-webkit-scrollbar { display: none !important; }
>     ::-webkit-resizer { display: none !important; }
> }
> 
> Perhaps this can go right into html.css? If not, maybe there’s some other
> way to introduce those style rules at the right time.

Great, idea, I'll try that. I also thought about something similar, injecting a user style sheet before printing and removing it afterwards, but this looks a lot cleaner to me.

> I suspect this will eliminate the need for any code changes in RenderLayer
> and RenderListBox; some small changes to FrameView or ScrollView might be
> needed, but they would likely be minimal, and also likely would fix bugs
> where these style rules aren’t properly respected.
> 
> Another thought: I don’t think the current patch covers all the cases. What
> about RenderMenuList and RenderSearchField? Should cover those with test
> cases too.

In both cases the scrollbars are in the popups, no? so I assumed the popups are always hidden when printing.

> I’m going to say r=me but I’d like to see a version with fewer code changes.
> The printing code should be reduced in complexity if possible rather than
> increased.

I agree, thanks for the review.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151201/85697aed/attachment.html>