[Webkit-unassigned] [Bug 147815] [GTK] [Stable] webkitgtk 2.8.5 fails to build in mips, powerpc and others using GCC 5

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147815

--- Comment #9 from Filip Pizlo <fpizlo at apple.com> ---
(In reply to comment #8)
> (In reply to comment #7)
> > Attachment 260169 [details] did not pass style-queue:
> > ERROR: Source/JavaScriptCore/ChangeLog:9:  Line contains tab character. 
> > [whitespace/tab] [5]
> > Total errors found: 1 in 2 files
> 
> This is the first project I have ever tripped over in which a GNU-style
> ChangeLog file was *not* to be indented with a single hard tab?
> 
> Anyway I would ask whoever commits this patch to fix up this trivial error
> for me; it does not seem worth respinning the whole thing over.  You're
> going to have to edit the changelog to put yourself on the "Reviewed by"
> line anyway ;-)

If you would like this change landed, then you should submit a patch that obeys our style.

Also, patches by non-committers are usually landed by the commit-queue after a committer grants the cq+ flag.  The commit-queue does not automatically fix style errors for you.  So, what you're asking is for is not only that some reviewer do some work for you, but that they land the patch for you rather than using the commit-queue.  Most reviewers have more important things to do than fix other people's style errors for them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150828/3d0df1ed/attachment.html>