[Webkit-unassigned] [Bug 148535] The status message for combined builder queues should say "all builds passed" if everything built correctly.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 27 16:57:34 PDT 2015


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #260073|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 260073
  --> https://bugs.webkit.org/attachment.cgi?id=260073

View in context: https://bugs.webkit.org/attachment.cgi?id=260073&action=review

r=me if you fix the nit.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:90
> +            var statusMessagePassed = "all " + (queue.builder ? "builds" : "tests") + " passed"

Nit: This should have a semi-colon at the end of the line.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150827/1c13171e/attachment-0001.html>

More information about the webkit-unassigned mailing list