[Webkit-unassigned] [Bug 148442] Fix crash due to animationDidEnd called on deallocated RemoteLayerTreeHost

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148442

--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 259977
  --> https://bugs.webkit.org/attachment.cgi?id=259977
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259977&action=review

>> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:145
>>      m_layers.remove(layerID);
> 
> 1) You can do the hash table lookup only once.
> 
> 2) Should you also cover the case in clearLayers()?

1. Good point. Fixed.

2. clearLayers is only invoked in the destructor of RemoteLayerTreeHost, which ensures that all animation delegates are first invalidated. It might be better to lift the invalidation logic from ~RemoteLayerTreeHost to clearLayers() instead though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150826/53740892/attachment.html>