[Webkit-unassigned] [Bug 147742] [ES6] Implement ES6 arrow function syntax. Prototype of arrow function should be undefined

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 26 06:39:06 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147742

--- Comment #6 from GSkachkov <gskachkov at gmail.com> ---
(In reply to comment #4)
> Comment on attachment 259456 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259456&action=review
> 
> > Source/JavaScriptCore/runtime/JSArrowFunction.cpp:70
> > +    removeDirect(vm, vm.propertyNames->prototype);
> 
> This is not necessary, and it's also quite wrong.  It's quite bad to remove
> properties; it puts the object into a conservative (i.e. slow) mode.  Also,
> there is no way for the object to have a "prototype" property at this point,
> since it's added lazily.

Hmm, it is really unnecessary. I've removed this code. Could you please make review one more time? 

Also something wrong with tests during build, because tests don't pass without my patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150826/bb58a56b/attachment.html>


More information about the webkit-unassigned mailing list