[Webkit-unassigned] [Bug 148425] New: Fix the !ENABLE(CSS_REGIONS) build after r188663

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 25 03:08:53 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148425

            Bug ID: 148425
           Summary: Fix the !ENABLE(CSS_REGIONS) build after r188663
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ossy at webkit.org
                CC: cdumez at apple.com, ggaren at apple.com
            Blocks: 148193

http://trac.webkit.org/changeset/188663 broke the !ENABLE(CSS_REGIONS) 
build, because JSDOMNamedFlowCollection class is defined inside guard.
( http://trac.webkit.org/browser/trunk/Source/WebCore/dom/DOMNamedFlowCollection.idl#L1 )

build log:

../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:37:6: error: 'JSDOMNamedFlowCollection' has not been declared
../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp: In function 'bool WebCore::nameGetter(JSC::ExecState*, JSC::PropertyName, JSC::JSValue&)':
../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:39:22: error: 'impl' was not declared in this scope
../../Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp:43:37: error: 'globalObject' was not declared in this scope
ninja: build stopped: subcommand failed.

There is no need for JSDOMNamedFlowCollection::nameGetter() outside the guard,
so let's guard the whole Source/WebCore/bindings/js/JSDOMNamedFlowCollectionCustom.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150825/b20815f7/attachment.html>


More information about the webkit-unassigned mailing list