[Webkit-unassigned] [Bug 148387] Add support to dashboard for displaying Git SHA's as revisions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 14:41:47 PDT 2015


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #259774|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 259774
  --> https://bugs.webkit.org/attachment.cgi?id=259774

View in context: https://bugs.webkit.org/attachment.cgi?id=259774&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:225
> +        else if (repository.isGit)
> +            // Truncating for display. Git traditionally uses seven characters for a short hash.
> +            content.textContent = revision.substr(0, 7);
> +        else

Please add curly-braces.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150824/e8d393a6/attachment.html>

More information about the webkit-unassigned mailing list