[Webkit-unassigned] [Bug 148387] Add support to dashboard for displaying Git SHA's as revisions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148387

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259764|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 259764
  --> https://bugs.webkit.org/attachment.cgi?id=259764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259764&action=review

We should add the isSVN property to the definition of the OpenSource repository in this patch. Otherwise, we will no longer prefix OpenSource revisions with 'r' following this patch.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:223
>> +            content.textContent = revision.substr(0, 7);
> 
> Are we okay with truncating this to 7 characters for display? Do we need to add any commit explaining the choice to truncate or the choice of 7 characters?

You could add a comment to explain that a SHA of 7 characters is sufficiently unique for our purposes.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:225
>> +            content.textContent = revision;
> 
> Should we instead throw an exception here? Or perhaps just leave the "else" clause out?

If you are going to handle each kind of SCM then you could add a console.assert(false, "Should not get here; " + repository.name + " did not specify a known VCS type."); Alternatively, you could write this logic such that Git is the special case and SVN is the fallback case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150824/493b5b6a/attachment.html>