[Webkit-unassigned] [Bug 148373] Create WebAssembly functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148373

--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 259748
  --> https://bugs.webkit.org/attachment.cgi?id=259748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259748&action=review

> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:68
> +        Vector<UnlinkedInstruction, 0, UnsafeVectorOverflow> instructions;
> +        instructions.append(op_enter);
> +        result->setInstructions(std::make_unique<UnlinkedInstructionStream>(instructions));

This seems wrong. What does op_enter mean in the web assembly context? What does it mean to have bytecode at all, when we don't have web assembly bytecodes?

> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:185
> +#if ENABLE(WEBASSEMBLY)
> +    unsigned m_isWebAssemblyFunction : 1;
> +    WriteBarrier<JSWASMModule> m_webAssemblyModule;
> +    unsigned m_webAssemblyFunctionIndex;
> +#endif

I think it would be clearer -- and better for memory use -- to add a webassembly subclass rather than building this into all function executables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150824/2fcc8a5c/attachment.html>