[Webkit-unassigned] [Bug 148289] Media Session: let UI clients change the volume of the focused media element
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 21 17:52:52 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=148289
--- Comment #5 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #3)
> Comment on attachment 259583 [details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259583&action=review
>
> Looks good to me.
>
> > Source/WebCore/page/Page.cpp:1232
> > + ExceptionCode code;
> > + element->setVolume(volume, code);
>
> Nit: you should use ASSERT_NO_EXCEPTION here.
Done.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150822/a27d3173/attachment.html>
More information about the webkit-unassigned
mailing list