[Webkit-unassigned] [Bug 148197] iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148197

--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
(In reply to comment #5)
> > Tools/Scripts/webkitpy/port/ios.py:-248
> > -        # testing_device will fail to boot if it is already booted. We assume that if testing_device
> > -        # is booted that it was booted by the iOS Simulator app (as opposed to simctl). So, quit the
> > -        # iOS Simulator app to shutdown testing_device.
> > -        # FIXME: <rdar://problem/20916140> Switch to using CoreSimulator.framework for launching and quitting iOS Simulator
> > -        self._executive.run_command(['osascript', '-e', 'tell application id "com.apple.iphonesimulator" to quit'])
> > -        Simulator.wait_until_device_is_in_state(testing_device.udid, Simulator.DeviceState.SHUTDOWN)
> > -
> 
> Actually, we need this code to handle the scenario where a person launched
> the iOS Simulator with simulator device testing_device and then subsequently
> runs run-webkit-test --ios-simulator (this is implied by the comment on
> lines 242 - 244). So, I suggest that we extract the common code into shared
> function, say _quitIOSSimulator, that we call from both here and
> clean_up_test_run().

Disregard this comment. We also need to move the logic for quitting the simulator from IOSSimulatorPort.check_sys_deps() to IOSSimulatorPort.reset_preferences(). Otherwise, we will hit this bug when a person launches the testing device in iOS Simulator and subsequently runs run-webkit-tests --ios-simulator.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150821/f5d85b36/attachment.html>