[Webkit-unassigned] [Bug 148197] iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148197

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259560|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 259560
  --> https://bugs.webkit.org/attachment.cgi?id=259560
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259560&action=review

> Tools/BuildSlaveSupport/kill-old-processes:88
> +        "Simulator"  #FIXME: Consider moving iOS-Specific tasks to their own list

Please put a space character after the '#', substitute "specific" for "Specific" and add a period to the end of this sentence.

> Tools/Scripts/webkitpy/port/ios.py:-248
> -        # testing_device will fail to boot if it is already booted. We assume that if testing_device
> -        # is booted that it was booted by the iOS Simulator app (as opposed to simctl). So, quit the
> -        # iOS Simulator app to shutdown testing_device.
> -        # FIXME: <rdar://problem/20916140> Switch to using CoreSimulator.framework for launching and quitting iOS Simulator
> -        self._executive.run_command(['osascript', '-e', 'tell application id "com.apple.iphonesimulator" to quit'])
> -        Simulator.wait_until_device_is_in_state(testing_device.udid, Simulator.DeviceState.SHUTDOWN)
> -

Actually, we need this code to handle the scenario where a person launched the iOS Simulator with simulator device testing_device and then subsequently runs run-webkit-test --ios-simulator (this is implied by the comment on lines 242 - 244). So, I suggest that we extract the common code into shared function, say _quitIOSSimulator, that we call from both here and clean_up_test_run(). Maybe something like:

def _quitIOSSimulator(self):
    # FIXME: <rdar://problem/20916140> Switch to using CoreSimulator.framework for launching and quitting iOS Simulator
    self._executive.run_command(['osascript', '-e', 'tell application id "com.apple.iphonesimulator" to quit'])

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150821/7d2e5a6c/attachment-0001.html>