[Webkit-unassigned] [Bug 147320] Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147320

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259523|review?                     |review+
              Flags|                            |

--- Comment #22 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 259523
  --> https://bugs.webkit.org/attachment.cgi?id=259523
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259523&action=review

> Source/WebCore/page/WheelEventDeltaFilter.h:46
> +    WEBCORE_EXPORT virtual FloatSize filteredDelta() const = 0;

Why is this function virtual? Both classes just return m_currentFilteredDelta

> Source/WebCore/page/WheelEventDeltaFilter.h:52
> +const size_t basicWheelEventDeltaFilterWindowSize = 3;

Don't think this needs to be in the header.

> Source/WebCore/page/WheelEventDeltaFilter.h:68
> +    virtual bool isFilteringDeltas() const override
> +    {
> +        return m_isTrackingDeltas;

Why the naming disparity?

> Source/WebCore/page/WheelEventDeltaFilter.h:80
> +    bool m_isTrackingDeltas;

{ false }

> Source/WebCore/page/mac/WheelEventDeltaFilterMac.h:58
> +    bool m_isFilteringDeltas { false };

Name differs from the basic filter. Why not move to the base class?

> Source/WebCore/page/mac/WheelEventDeltaFilterMac.mm:38
> +    , m_predominantAxisFilter([[_NSScrollingPredominantAxisFilter alloc] init])

This is a leak. You need an adoptNS here.

> Source/WebCore/platform/spi/mac/NSScrollingInputFilterSPI.h:39
> +- (BOOL)resetIfOutOfDate:(NSTimeInterval)timestamp;

Unused. Only declare things you actually use.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150821/5bcae6bd/attachment-0001.html>