[Webkit-unassigned] [Bug 148188] Make Dashboard.Branches be objects of the form {repository, branchName} and update existing code to work with these new objects.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 17:30:27 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148188

--- Comment #2 from Jason Marcell <jmarcell at apple.com> ---
Comment on attachment 259400
  --> https://bugs.webkit.org/attachment.cgi?id=259400
=Make Dashboard.Branches be objects of the form {repository, branchName} and update existing code to work with these new objects.

View in context: https://bugs.webkit.org/attachment.cgi?id=259400&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:212
> +                key = repository.name;

This should be 'repositoryName'

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:215
>              this.revision[repository] = parseRevisionProperty(revisionProperty, key, fallbackKey);

This should be
this.revision[repositoryName] ...

I'll upload a new patch that addresses these two issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150820/ec99658f/attachment.html>


More information about the webkit-unassigned mailing list