[Webkit-unassigned] [Bug 148197] iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 19 16:46:01 PDT 2015


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #259414|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 259414
  --> https://bugs.webkit.org/attachment.cgi?id=259414
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259414&action=review

> Tools/Scripts/webkitpy/port/ios.py:387
> +        self._executive.run_command(['osascript', '-e', 'tell application id "com.apple.iphonesimulator" to quit'])
> +        quit_delay = 5
> +        _log.debug('Waiting {seconds} seconds for any old iOS Simulator instance to quit ...'.format(seconds=quit_delay))
> +        time.sleep(quit_delay)
>          if os.path.isdir(data_path):
>              shutil.rmtree(data_path)

Is it necessary to remove the data directory? I mean, check_sys_deps() will conditionally erase the simulator device using "simctl erase", which will delete the data directory. If it is not necessary then I suggest we have this function be empty (except for the presence of the pass keyword - since Python does not allow a function to have an empty body). If it is necessary to remove the data directory here then can we make use of Simulator.check_simulator_device_and_erase_if_needed() or extract the logic from this function into a shared function that can be called here and in Simulator.check_simulator_device_and_erase_if_needed()? Can we make use of Simulator.wait_until_device_is_in_state() to wait until the booted simulator device is shutdown instead of waiting a hardcoded 5 seconds.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150819/e6e443fc/attachment.html>

More information about the webkit-unassigned mailing list