[Webkit-unassigned] [Bug 148190] Web Inspector: Uncaught Exceptions regarding PseudoElements / TemplateContent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148190

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259402|review?                     |review+
              Flags|                            |

--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 259402
  --> https://bugs.webkit.org/attachment.cgi?id=259402
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=259402&action=review

r=me

> Source/WebInspectorUI/ChangeLog:14
> +        exists, it may be null. So separate the two pathes.

paths*

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:289
> +        for (let i = 0; node.children && i < node.children.length; ++i)

This could be for (let .. of ..), since it doesn't mutate node.children.

> Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:296
> +        let pseudoElements = node.pseudoElements();

No need for a local.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150819/af8a300b/attachment.html>