[Webkit-unassigned] [Bug 148035] [ES6] Add TypedArray.prototype functionality.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 16:13:58 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148035

--- Comment #17 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 259195
  --> https://bugs.webkit.org/attachment.cgi?id=259195
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259195&action=review

>> Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:102
>> +    TypeConverter* unionArray = bitwise_cast<TypeConverter*>(floatArray);
> 
> This.... probably doesn't do what you think it does.

To clarify here, our strategy is to read the array as if it were a union, to avoid strict aliasing violation. That means the initial cast of the pointer to first member can be reinterpret_cast, and all subsequent access should be through the union type, which means we should not bitwise cast below, and we should sort an array of union and not an array of int.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150818/0cb13526/attachment.html>


More information about the webkit-unassigned mailing list