[Webkit-unassigned] [Bug 148142] Add metadata to Dashboard.Repository for SCM type.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 14:33:56 PDT 2015


--- Comment #2 from Jason Marcell <jmarcell at apple.com> ---
Comment on attachment 259297
  --> https://bugs.webkit.org/attachment.cgi?id=259297

View in context: https://bugs.webkit.org/attachment.cgi?id=259297&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:28
> +    GIT: 1

Should this be GIT in all caps? For that matter, is SVN an appropriate key for Subversion?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:32
> +    SCMTypes: SCMTypes,

I defined SCMTypes outside of Dashboard so that I could refer to it in the Dashboard.Repository section. But I also want to refer to them as Dashboard.SCMTypes.SVN, etc., so I added a key "SCMTypes" here. I don't really like this, but I'm open to other suggestions.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150818/1e036878/attachment.html>

More information about the webkit-unassigned mailing list