[Webkit-unassigned] [Bug 125868] Crash when trying to copy image

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 18 09:22:32 PDT 2015


--- Comment #4 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 259133
  --> https://bugs.webkit.org/attachment.cgi?id=259133
Patch to reduce memory usage and CPU time.

View in context: https://bugs.webkit.org/attachment.cgi?id=259133&action=review

> Source/WebCore/ChangeLog:12
> +        No new tests needed.

Why are not no new tests needed for this change?

> Source/WebCore/platform/mac/PasteboardMac.mm:258
> +    NSData *imageData = (NSData*)(pasteboardImage.image->getTIFFRepresentation());

I think this is wrong. The clipboard has to manage deallocating its own data. The original data can be freed or even the whole application gets shut down but the clipboard should keep its data. In other words, I think a new memory buffer has to be allocated every time we want to write to the clipboard.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150818/652c486c/attachment.html>

More information about the webkit-unassigned mailing list