[Webkit-unassigned] [Bug 148020] GraphicsContext3D::activeTexture should not be called with zero-based index

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148020

--- Comment #5 from Jinyoung Hur <hur.ims at navercorp.com> ---
(In reply to comment #3)
> Comment on attachment 258989 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=258989&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        No new tests because there is no behavior change.
> 
> There should be a behavior change since there is a bug in passing the wrong
> parameter value to GraphicsContext3D::activeTexture(). Can not we have a
> layout test or even a test case which shows the rendering difference between
> before and after the fix?
> 
> > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4064
> > +        m_context->activeTexture(m_activeTextureUnit + GraphicsContext3D::TEXTURE0);
> 
> Yes this looks a correct fix. This can be verified from
> https://www.khronos.org/opengles/sdk/docs/man/xhtml/glActiveTexture.xml and
> from WebGLRenderingContextBase::activeTexture() in which we set
> m_activeTextureUnit = texture - GraphicsContext3D::TEXTURE0.

Thank you for review.
I'll try to include a test case that shows the behavior difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150818/4b9916e0/attachment.html>