[Webkit-unassigned] [Bug 125868] Crash when trying to copy image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125868

Jeremy Zerfas <WebKit at JeremyZerfas.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |WebKit at JeremyZerfas.com

--- Comment #2 from Jeremy Zerfas <WebKit at JeremyZerfas.com> ---
I was able to reproduce this bug on a freshly installed Mavericks virtual machine that was set up with 2 GB of memory. It looks like the crashes were happening due to all the memory that is required when processing the animated GIF (800x600 resolution x 439 frames in the animation * 32 bits per pixel = ~804 MiB when uncompressed). Updating to Safari 7.1.8 seems to largely have resolved the issue by getting rid of the crashes. However during and after copying an image into the clipboard Safari still seems to be using up more memory than is necessary.

While looking at this bug I did notice that when copying an image to the clipboard, WebKit allocates an NSImage that isn't needed. The patch I'm adding causes it to to not allocate the NSImage. With the animation from this bug, the patch considerably reduces the amount of memory and CPU time used when copying an image to the clipboard. Originally when copying the animation on my Mac, the resident memory size would increase to ~2,750 MiB. With the patch applied the resident memory size only increases up to ~1,150 MiB and the process also finishes about 1.75 seconds faster.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150817/23e2891c/attachment.html>