[Webkit-unassigned] [Bug 147961] Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with repositories other than "openSource" and "internal".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147961

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258946|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 258946
  --> https://bugs.webkit.org/attachment.cgi?id=258946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258946&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:174
> +                if (lines.length)
> +                    shouldAddDivider = true;

This is not correct. Suppose there three repositories A, B, C and when processing these repositories (in this order) lines.length = 1, 0, 1, respectively. Then the output content will look like A_1, "divider", "divider", C_1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150814/662c3cef/attachment-0001.html>