[Webkit-unassigned] [Bug 144956] [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 14 09:14:56 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=144956

--- Comment #124 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 258823
  --> https://bugs.webkit.org/attachment.cgi?id=258823
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258823&action=review

>> Source/JavaScriptCore/dfg/DFGMayExit.cpp:111
>> +    case LoadArrowFunctionThis:
> 
> This sort of can exit.  It speculates that its child is a cell.

Removed from this list

>> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3115
>> +            : FTL_NEW_BLOCK(m_out, ("NewFunction slow path"));
> 
> Just call it NewFunction.  No need for these branches just to get a different basic block name.

Done

>> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3119
>> +            : FTL_NEW_BLOCK(m_out, ("NewFunction continuation"));
> 
> Ditto.

Done

>> Source/JavaScriptCore/runtime/JSArrowFunction.h:92
>> +friend class LLIntOffsetsExtractor;
> 
> Indent this line.

Done

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150814/45f6548d/attachment.html>


More information about the webkit-unassigned mailing list