[Webkit-unassigned] [Bug 147997] AppScale: Assertion hit when hovering a webkit-queue bubble

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 16:34:31 PDT 2015


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #258950|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 258950
  --> https://bugs.webkit.org/attachment.cgi?id=258950
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258950&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:136
> +            console.assert(this.statusPageURL.replace(/.*?:\/\//g, "") === data.status_page.replace(/.*?:\/\//g, ""));

This replace removes anything before a colon, which I think is incorrect. E.g. "foo://bar://baz".replace(/.*?:\/\//g, "") -> "baz".

How about something like "/^https?://" ?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150813/b3733ae9/attachment.html>

More information about the webkit-unassigned mailing list