[Webkit-unassigned] [Bug 148001] New: [Win] Replace the MIDL comments ([in], [inout]) in interface code with equivalent SAL declarations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 13 16:17:23 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148001

            Bug ID: 148001
           Summary: [Win] Replace the MIDL comments ([in], [inout]) in
                    interface code with equivalent SAL declarations
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

Our Windows COM interfaces are peppered with old, possibly invalid comments based on the IDL used to generate the original Windows headers years ago.

Instead, we should have the MIDL compiler generate output with appropriate SAL declarations, and modify our Windows code to use the right SAL declarations instead of these comments.

While this won't make the code any prettier on Windows, it has the advantage of allowing the compiler tell us if any of our implementations deviate from the interface declarations, and will help Microsoft's static analyzer do a better job of analyzing our Windows code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150813/28144096/attachment.html>


More information about the webkit-unassigned mailing list